-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMake][feat] Support FetchContent use #519
Conversation
is there any way to support FetchContent with cmake 3.15? |
we need some time to review, this afternoon .
maybe we can do this without upgrade cmake version |
Reading property PARENT_DIRECTORY may work . |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you!
Why
related to issue : #505
Make FetchContent available without any test or example target built
What is changing
1. CMake version requirement is up ( 3.15 => 3.21)2. Subdirectories will not add into project unless project is top-level .
3. Add some
$<INSTALL_INTERFACE>
and$<BUILD_INTERFACE>
to avoid explicit callinclude_directories
outsideExample
Simple testing used